vanilla-framework icon indicating copy to clipboard operation
vanilla-framework copied to clipboard

p-divider__block doesn't handle responsive columns.

Open huwshimi opened this issue 3 years ago • 1 comments

Describe the bug

When using p-divider__block with responsive columns (e.g. col-medium-...) the dividers move to horizontal before the columns.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://codepen.io/huwshimi/pen/VwyJjVY
  2. Resize your window down to medium size.
  3. See that the columns are still horizontal but the borders move to the top.
  4. Resize down to mobile and the columns and borders are back to looking correct.

Expected behavior

The borders should stay horizontal.

Screenshots

The border is correct at large size:

Screen Shot 2022-04-26 at 11 27 35 am

Changing to medium the borders move to the top but because of the col-medium-... classes the columns stay where they were:

Screen Shot 2022-04-26 at 11 27 43 am

At mobile size all's right in the world again:

Screen Shot 2022-04-26 at 11 28 22 am

Additional context

This might require additional classes to correctly set the borders at each size, but at the moment (as far as I can see) there isn't a way to fix this without a custom implementation of p-divider__block.

huwshimi avatar Apr 26 '22 01:04 huwshimi

I don't think it was intended to support mobile columns, just a predefined layout.

But I agree that the fact that it uses grid class names directly suggest any other grid class names can be used (including responsive). We need to take a look if that's something we can fix (make it work with any grid columns), or we have to limit it to one predefined layout.

bartaz avatar May 05 '22 07:05 bartaz