vanilla-framework icon indicating copy to clipboard operation
vanilla-framework copied to clipboard

Search and filter search prompt should match the contextual menu dropdown

Open sowasred2012 opened this issue 3 years ago • 4 comments

The search and filter search prompt is currently very spacious, and includes padding at the top that makes it look as though it has a thick, white top border:

Screenshot from 2021-07-14 10-32-59.png

We should make this search prompt look similar to the contextual menu dropdown (without the fixed width):

Screenshot from 2021-07-14 10-33-09.png

sowasred2012 avatar Jul 14 '21 09:07 sowasred2012

@ziheliu214 @lyubomir-popov could you review this and check you're happy with this change?

cristinadresch avatar Jul 15 '21 08:07 cristinadresch

@sowasred2012 My intention was to keep the search prompt spacious to differentiate with the categories and items below in the menu. e.g. in the case here:Screenshot 2021-07-15 at 14 46 39

Noticed the white border - the grey background was supposed to be a hover state, but now it seems to be always there and not aligned with the menu border.

So I guess the solution can be, to make the menu upper border lower to the grey area, or remove the grey and put hover state on the search prompt instead.

@lyubomir-popov What do you think?

ziheliu214 avatar Jul 15 '21 13:07 ziheliu214

@ziheliu214 @sowasred2012 I agree the gray should be a hover state. the height of the area highlighted by the grey hover should be consistent with other similar elements like the contextual menu and side navigation. No need for the top sliver of white if it can be avoided.

lyubomir-popov avatar Jul 21 '21 12:07 lyubomir-popov

@sowasred2012 this should be ready for development. Let me know if you need anything.

lyubomir-popov avatar Jul 26 '21 08:07 lyubomir-popov