vanilla-framework icon indicating copy to clipboard operation
vanilla-framework copied to clipboard

Colours rows in table example misleading

Open anthonydillon opened this issue 4 years ago • 2 comments

The example below is misleading people that these coloured rows are available and provided by Vanilla. https://vanillaframework.io/docs/examples/patterns/tables/table-colored-rows

Some options but not an exhaustive list:

  • Add a comment to the top of the example stating this is not an example of Vanilla but just a browser test
  • Create a new category of example which is not listed in the /examples page
  • Remove the examples section altogether from the site and add a link from the examples in the docs to the raw exampl

anthonydillon avatar Jan 22 '21 16:01 anthonydillon

Remove the examples section altogether from the site

It might promote Vanilla to have a single “Gallery” page with examples of Vanilla’s more-distinctive patterns all on one page. Apart from that, though, having “Examples” separate from “Docs” constantly risks them getting out of sync like this, or people looking at a pattern in one section and not noticing that it’s also represented in the other section.

A challenge might be reimplementing the “Toggle baseline grid” function within the docs.

matthewpaulthomas avatar Jan 24 '21 10:01 matthewpaulthomas

This will be solved by creating a separate section of examples for bugs/regression/etc (so that we differentiate between examples for users and the ones just for Percy).

SirSamTumless avatar Jan 26 '21 09:01 SirSamTumless