ubuntu.com icon indicating copy to clipboard operation
ubuntu.com copied to clipboard

add check for contractItemID validity to prevent 500

Open usamabinnadeem-10 opened this issue 1 year ago • 4 comments

Done

  • Add a check for contractItemID query parameter when scheduling an exam to prevent 500 error

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/
    • Be sure to test on mobile, tablet and desktop screen sizes
  • Purchase and schedule an exam and it should go through

Issue / Card

Fixes WD-16047

Help

QA steps - Commit guidelines

usamabinnadeem-10 avatar Oct 18 '24 11:10 usamabinnadeem-10

This is not relevant to the error btw

abhigyanghosh30 avatar Oct 18 '24 12:10 abhigyanghosh30

The error is here https://sentry.is.canonical.com/canonical/ubuntu-com/issues/93025/?query=is%3Aunresolved%20cred

abhigyanghosh30 avatar Oct 18 '24 12:10 abhigyanghosh30

@abhigyanghosh30 the error is related to the contractItemID being an empty string. Previously the id was being read from the form but now I am extracting that directly from the query and if it is not present we show an error and don't schedule the exam in that scenario.

usamabinnadeem-10 avatar Oct 18 '24 12:10 usamabinnadeem-10

@abhigyanghosh30 can you reply to the last comment please?

anthonydillon avatar Nov 23 '24 08:11 anthonydillon

Added comment in the PR review. It has not been addressed yet

abhigyanghosh30 avatar Nov 23 '24 08:11 abhigyanghosh30

@usamabinnadeem-10 is this still relevant?

anthonydillon avatar May 01 '25 08:05 anthonydillon

@usamabinnadeem-10 is this still relevant?

This could not be reproduced as mentioned in this ticket https://warthogs.atlassian.net/browse/WD-16047 I am closing this.

usamabinnadeem-10 avatar May 02 '25 11:05 usamabinnadeem-10