ubuntu.com icon indicating copy to clipboard operation
ubuntu.com copied to clipboard

Vanilla Macro loader example (DO NOT MERGE)

Open pastelcyborg opened this issue 1 year ago • 5 comments

This PR exists solely to demonstrate examples and experiments for loading Vanilla Macros from node_modules/ using Flask/Jinja. A permanent solution will likely be integrated into Flask Base directly.

DO NOT MERGE.

pastelcyborg avatar Aug 20 '24 21:08 pastelcyborg

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.51%. Comparing base (483cdcf) to head (8d5943a). Report is 1682 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14209      +/-   ##
==========================================
- Coverage   69.57%   69.51%   -0.06%     
==========================================
  Files         120      120              
  Lines        3412     3412              
  Branches     1176     1172       -4     
==========================================
- Hits         2374     2372       -2     
- Misses       1013     1015       +2     
  Partials       25       25              

see 1 file with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 20 '24 21:08 codecov[bot]

This is great, thank you! :)

I tried running the example on demo and it's throwing 500, running it locally shows that the macros are not found. Screenshot 2024-08-22 at 10 32 23 AM

Upon checking, there are no templates/ files under node_modules/vanilla_framework. Is this soon to be added from Vanilla's side?

britneywwc avatar Aug 22 '24 02:08 britneywwc

This is great, thank you! :)

I tried running the example on demo and it's throwing 500, running it locally shows that the macros are not found. Screenshot 2024-08-22 at 10 32 23 AM

Upon checking, there are no templates/ files under node_modules/vanilla_framework. Is this soon to be added from Vanilla's side?

Vanilla in this project would need to be upgraded to at least 4.15.0 to get the patterns.

pastelcyborg avatar Aug 22 '24 14:08 pastelcyborg

@britneywwc Actually, a few other minor changes will need to be made to Vanilla as well, because the macros directory is not currently published as part of the npm package, so unfortunately this server change won't be useful until those changes are made. Sorry about that!

pastelcyborg avatar Aug 22 '24 19:08 pastelcyborg