ubuntu.com icon indicating copy to clipboard operation
ubuntu.com copied to clipboard

Hide error message when value changes

Open britneywwc opened this issue 1 year ago • 2 comments

Done

  • Hide global error message when any field is updated
  • Applied suggestions from https://github.com/canonical/ubuntu.com/pull/12759

QA

  • Go to /pro/subscribe

  • Click "Buy now" button

  • Type invalid VAT number and check global error message displays properly

  • Update VAT field with new number, error message should disappear when the field is updated

  • Type invalid card number and check global error message displays properly

  • Update card number with valid number, save and check that the global error message disappears

  • QA with other error cases as well

Issue / Card

Fixes WD-2941

Screenshots

[If relevant, please include a screenshot.]

Help

QA steps - Commit guidelines

britneywwc avatar Mar 04 '24 09:03 britneywwc

Demo starting at https://ubuntu-com-13640.demos.haus

webteam-app avatar Mar 04 '24 09:03 webteam-app

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.41%. Comparing base (118a569) to head (6e26dd6). Report is 2907 commits behind head on main.

Files with missing lines Patch % Lines
.../checkout/components/UserInfoForm/UserInfoForm.tsx 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13640      +/-   ##
==========================================
- Coverage   74.46%   74.41%   -0.06%     
==========================================
  Files         107      107              
  Lines        2847     2849       +2     
  Branches      948      948              
==========================================
  Hits         2120     2120              
- Misses        703      705       +2     
  Partials       24       24              
Files with missing lines Coverage Δ
.../checkout/components/UserInfoForm/UserInfoForm.tsx 64.56% <0.00%> (-0.52%) :arrow_down:

... and 1 file with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 04 '24 09:03 codecov[bot]

@britneywwc Is this PR still relevant?

Onibenjo avatar May 02 '25 15:05 Onibenjo

I'll close this PR as it's no longer relevant, thanks @Onibenjo

britneywwc avatar May 05 '25 05:05 britneywwc