ubuntu.com icon indicating copy to clipboard operation
ubuntu.com copied to clipboard

24.04

Open akbarkz opened this issue 1 year ago • 2 comments

Done

  • A feature branch for 24.04 release. Will be merged when the release is ready.

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/
    • Be sure to test on mobile, tablet and desktop screen sizes

Help

QA steps - Commit guidelines

akbarkz avatar Feb 01 '24 03:02 akbarkz

Demo starting at https://ubuntu-com-13522.demos.haus

webteam-app avatar Feb 01 '24 03:02 webteam-app

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.51%. Comparing base (9cd1650) to head (17fe099). Report is 20 commits behind head on main.

:exclamation: Current head 17fe099 differs from pull request most recent head 9a3d6a0. Consider uploading reports for the commit 9a3d6a0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13522   +/-   ##
=======================================
  Coverage   74.51%   74.51%           
=======================================
  Files         107      107           
  Lines        2857     2857           
  Branches      957      957           
=======================================
  Hits         2129     2129           
  Misses        704      704           
  Partials       24       24           

codecov[bot] avatar Feb 01 '24 03:02 codecov[bot]

In /download/desktop:

  • [x] Remove the attr from the download CTA
  • [x] Add the deep dive link under “What’s new” and tweak the release notes link label as indicated in the copy doc
  • [x] Tweak the third item (Raspberry Pi) under “Resources” as indicated in the copy doc. Please add an   between Raspberry and Pi in the link 🙏
  • [x] Please also change the two links to /raspberry-pi under "More from Canonical" so they point to /download/raspberry-pi instead ~~(PR from @carkod https://github.com/canonical/ubuntu.com/pull/13775)~~

Elsewhere:

  • [ ] In /download/desktop and /download/server on mobile, the spacing around the mascot is awkward (see below). @lyubomir-popov should we tweak? (Looks a bit better on /download/raspberry-pi)

ubuntu-com-13522 demos haus_download_desktop(iPhone SE)

  • [x] The Certified hardware sections don't look to good on /download/desktop (see below) and /download/core: logos wrap in both cases, and logos are differently sized. Can we try to improve that a bit? @mtruj013 I think your fix for /desktop would work well at least for /download/desktop, I see Core has more icons though.

ubuntu-com-13522 demos haus_download_desktop(iPhone SE) (2)

  • [x] In /download/core, change the label of the “About Ubuntu Core” hero link and turn into a default button as indicated in the copy doc, same as we did on /download/desktop
  • [x] In /desktop, the screenshot is lacking some space below.
  • [x] In /desktop, please fix the capitalisation in “Virtual desktops with Amazon WorkSpaces”
  • [x] Remove the /raspberry-pi bubble and redirect to /download/raspberry-pi, I’ve created a ticket for that. (PR from @carkod https://github.com/canonical/ubuntu.com/pull/13775)
  • [x] Redirect https://ubuntu.com/download/server/choose to https://ubuntu.com/download/server#automated-provisioning
  • [x] Redirect https://ubuntu.com/download/server/multipass to https://ubuntu.com/download/server#instant-vms

@mtruj013 @carkod About the image file sizes: I understand we don’t know the sizes of the images yet, but we are showing them in the demo. Lukasz will be providing them with the checksums. I suggest that we build this in a way that just hides the value when we don’t have them in the YAML. No data is fine, wrong data is not. I also wonder if we should use a similar structure as checksums do on the releases.yaml file, but that's for you to decide of course. Finally, I see the Core 22 size for Raspberry Pi is still hardcoded.

I'm also spotting some bugs on the meganav, but I am reporting them separately.

juanruitina avatar Apr 19 '24 11:04 juanruitina

@juanruitina checked changes in the above list addressed here

mtruj013 avatar Apr 24 '24 08:04 mtruj013