ubuntu.com icon indicating copy to clipboard operation
ubuntu.com copied to clipboard

Implement /credentials/shop/manage as flask view

Open britneywwc opened this issue 1 year ago • 2 comments

Done

  • Blocked by https://github.com/canonical/ubuntu.com/pull/13464
  • Implementing credentials/shop/manage in Flask view, previously a React App
  • Redesign tab selection to dropdown select
  • Remove the option to rotate/redeem key if key has expired
  • Update tooltip message when key is copied

QA

  • Go to https://ubuntu-com-13422.demos.haus/credentials/shop/manage
  • Check that the dropdown tabs filter correctly
  • Check that the keys are copied
  • Check that the keys can be rotated repeatedly

Issue / Card

Fixes WD-7950, WD-9176

Help

QA steps - Commit guidelines

britneywwc avatar Jan 03 '24 13:01 britneywwc

Demo starting at https://ubuntu-com-13422.demos.haus

webteam-app avatar Jan 03 '24 13:01 webteam-app

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.46%. Comparing base (e93384d) to head (0fdaed9). Report is 3 commits behind head on main.

:exclamation: Current head 0fdaed9 differs from pull request most recent head ed12542

Please upload reports for the commit ed12542 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13422      +/-   ##
==========================================
+ Coverage   74.12%   74.46%   +0.33%     
==========================================
  Files         107      107              
  Lines        2864     2847      -17     
  Branches      957      948       -9     
==========================================
- Hits         2123     2120       -3     
+ Misses        715      703      -12     
+ Partials       26       24       -2     

see 11 files with indirect coverage changes

codecov[bot] avatar Jan 03 '24 13:01 codecov[bot]

@britneywwc is this still relevant?

anthonydillon avatar May 01 '25 08:05 anthonydillon

@anthonydillon I spoke to @usamabinnadeem-10 and he mentioned that there are plans to migrate the codebase to React/Next eventually. I'll close this PR as it is no longer relevant, thanks.

britneywwc avatar May 05 '25 04:05 britneywwc