ubuntu.com
ubuntu.com copied to clipboard
Disable support for 14.04
Fixes canonical/commercial-squad#729
Co-authored-by: minkyngkm [email protected]
Done
- Disable infra support for 14.04
- Add tests
QA
- Go here
- select full support
- go back up and select 14.04
- "no support" should be selected and the other options should be disabled
Demo starting at https://ubuntu-com-12173.demos.haus/pro/subscribe
Codecov Report
Merging #12173 (bceaa10) into main (9039d76) will increase coverage by
0.26%
. The diff coverage is100.00%
.
:exclamation: Current head bceaa10 differs from pull request most recent head cc1fb59. Consider uploading reports for the commit cc1fb59 to get more accurate results
@@ Coverage Diff @@
## main #12173 +/- ##
==========================================
+ Coverage 63.35% 63.61% +0.26%
==========================================
Files 117 117
Lines 2737 2691 -46
Branches 808 791 -17
==========================================
- Hits 1734 1712 -22
+ Misses 960 937 -23
+ Partials 43 42 -1
Impacted Files | Coverage Δ | |
---|---|---|
...ubscribe/react/components/Form/Support/Support.tsx | 42.85% <100.00%> (+12.85%) |
:arrow_up: |
...rc/advantage/subscribe/react/utils/FormContext.tsx | 80.00% <100.00%> (-2.09%) |
:arrow_down: |
...js/src/advantage/offers/components/Offer/Offer.tsx | 66.66% <0.00%> (-1.52%) |
:arrow_down: |
...ptions/SubscriptionDetails/SubscriptionDetails.tsx | 74.48% <0.00%> (-0.76%) |
:arrow_down: |
...ns/SubscriptionDetails/DetailsTabs/DetailsTabs.tsx | 92.59% <0.00%> (-0.18%) |
:arrow_down: |
...ubscribe/react/components/Form/Version/Version.tsx | 96.29% <0.00%> (-0.14%) |
:arrow_down: |
static/js/src/PurchaseModal/PurchaseModal.tsx | 2.43% <0.00%> (ø) |
|
static/js/src/advantage/tests/factories/api.ts | 100.00% <0.00%> (ø) |
|
...rc/PurchaseModal/components/ModalSteps/StepTwo.tsx | 0.00% <0.00%> (ø) |
|
... and 10 more |
@minkyngkm isn't this other pr the same as this one? They look the same just with different target branches? If that's the case we can just merge this one to main and then rebase the new checkout branch.
@jpmartinspt ah yes its exactly the same! I thought we had to make 2 PRs one for the existing checkout and one for new checkout for some reason! If it's not necessary, yes we should close one PR! 👍
Merge this one to main and close the other one.