ubuntu.com icon indicating copy to clipboard operation
ubuntu.com copied to clipboard

Update dependency @canonical/global-nav to v3

Open renovate[bot] opened this issue 2 years ago • 2 comments

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@canonical/global-nav 2.7.0 -> 3.1.4 age adoption passing confidence

Release Notes

canonical-web-and-design/global-nav

v3.1.4

Compare Source

v3.1.3

Compare Source

v3.1.2

Compare Source

v3.1.1

Compare Source

v3.1.0

Compare Source

v3.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

renovate[bot] avatar Jul 14 '22 17:07 renovate[bot]

renovate[bot] is not a collaborator of the repo

webteam-app avatar Jul 14 '22 17:07 webteam-app

Codecov Report

Merging #11843 (43fe2a5) into main (f684d09) will decrease coverage by 0.04%. The diff coverage is n/a.

:exclamation: Current head 43fe2a5 differs from pull request most recent head a4ca036. Consider uploading reports for the commit a4ca036 to get more accurate results

@@            Coverage Diff             @@
##             main   #11843      +/-   ##
==========================================
- Coverage   73.54%   73.50%   -0.04%     
==========================================
  Files         105      105              
  Lines        2680     2665      -15     
  Branches      824      811      -13     
==========================================
- Hits         1971     1959      -12     
+ Misses        683      680       -3     
  Partials       26       26              
Impacted Files Coverage Δ
.../checkout/components/UserInfoForm/UserInfoForm.tsx 53.12% <0.00%> (-2.44%) :arrow_down:
.../js/src/advantage/offers/tests/factories/offers.ts 100.00% <0.00%> (ø)
...js/src/advantage/offers/components/Offer/Offer.tsx 100.00% <0.00%> (ø)

codecov[bot] avatar Oct 01 '22 12:10 codecov[bot]

Closing as u.com does not use this navigation anymore. We are waiting on the meganav work to be completed.

petesfrench avatar Apr 11 '23 12:04 petesfrench

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 3.x releases. However, if you upgrade to 3.x manually then Renovate will reenable minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

renovate[bot] avatar Apr 11 '23 12:04 renovate[bot]

Hey @petesfrench! Would there be any way we can update Ubuntu Advantage to Ubuntu Pro on the global nav on ubuntu.com? I think this PR included that update too but since this PR was closed, I wonder how we could update that..!

Screenshot 2023-04-12 at 8 42 44 am

minkyngkm avatar Apr 12 '23 07:04 minkyngkm

Hi @minkyngkm, we spoke about it yesterday in standup and decided to wait until the meganav work was merged. Merging this will break it, so that is not an option. If it is really crucial that the change is made now, we could look at adding some JS to temporarily update it, however, I would be against this.

petesfrench avatar Apr 12 '23 08:04 petesfrench