ubuntu.com icon indicating copy to clipboard operation
ubuntu.com copied to clipboard

Copy update on /desktop/organisations

Open minkyngkm opened this issue 2 years ago • 7 comments

Blocked : waiting on a whitepaper Don't merge: can't go live until we get the thumbs up from @local-optimum

Done

  • Copy update on /desktop/organisations

QA

  • Go to https://ubuntu-com-11813.demos.haus/desktop/organisations
  • Compare page against copy doc

Issue / Card

Fixes #https://github.com/canonical-web-and-design/web-squad/issues/5617

minkyngkm avatar Jul 07 '22 08:07 minkyngkm

Demo starting at https://ubuntu-com-11813.demos.haus

webteam-app avatar Jul 07 '22 08:07 webteam-app

Codecov Report

Merging #11813 (59cf5cf) into main (73dda49) will increase coverage by 5.30%. The diff coverage is n/a.

:exclamation: Current head 59cf5cf differs from pull request most recent head 2f97951. Consider uploading reports for the commit 2f97951 to get more accurate results

@@            Coverage Diff             @@
##             main   #11813      +/-   ##
==========================================
+ Coverage   58.86%   64.17%   +5.30%     
==========================================
  Files         112      119       +7     
  Lines        2616     2635      +19     
  Branches      727      776      +49     
==========================================
+ Hits         1540     1691     +151     
+ Misses       1012      902     -110     
+ Partials       64       42      -22     
Impacted Files Coverage Δ
...react/components/Subscriptions/Content/Content.tsx 61.29% <0.00%> (-10.71%) :arrow_down:
...DetailsTabs/components/FeaturesTab/FeaturesTab.tsx 84.28% <0.00%> (-1.43%) :arrow_down:
...src/advantage/subscribe/react/hooks/usePreview.tsx 8.33% <0.00%> (-0.76%) :arrow_down:
static/js/src/advantage/ecom-events.js 0.00% <0.00%> (ø)
.../src/advantage/subscribe/react/utils/test/Mocks.js 100.00% <0.00%> (ø)
...Modal/components/FreeTrialRadio/FreeTrialRadio.tsx 100.00% <0.00%> (ø)
...ubscriptions/SubscriptionList/SubscriptionList.tsx 54.54% <0.00%> (ø)
...ptions/SubscriptionDetails/SubscriptionDetails.tsx 69.13% <0.00%> (ø)
...scriptionDetails/DetailsContent/DetailsContent.tsx 88.88% <0.00%> (ø)
...c/advantage/subscribe/renderers/version-details.js
... and 16 more

codecov[bot] avatar Jul 07 '22 08:07 codecov[bot]

Hey @minkyngkm couple of notes:

  • [x] The pricing table first column says Ubuntu Pro Desktop 'advanced support' that one should be just Ubuntu Pro Desktop
  • [x] The intro sentence for Ubuntu Pro Desktop says 'premium service description' it should say 'premium service subscription' that was my bad sorry!
  • [x] Please remove the NVIDIA icon from the best of open source (if we could do that one change now on the live site that would be good)
  • [x] I think the rest is fine for now but just working with lech on his /pro page and might want to move our pricing table to a /pro/desktop page. Working on that idea now and will update here on if it's needed

local-optimum avatar Jul 12 '22 09:07 local-optimum

Thanks @sowasred2012 and @local-optimum for reviewing! I made some updates. Feel free to take a second look please :)

minkyngkm avatar Jul 13 '22 06:07 minkyngkm

Thanks @minkyngkm doesn't look like the demo page has updated yet but will take a look shortly. One final request for now is that we replace the laptop image with a Dell Precision Workstation, the same one used in the Data Sheet (I think Marcus may have the original) https://assets.ubuntu.com/v1/0af12937-Ubuntu.Desktop.DS.23.05.22.2.pdf

local-optimum avatar Jul 13 '22 08:07 local-optimum

Thanks @local-optimum. It's been updated!

minkyngkm avatar Jul 14 '22 07:07 minkyngkm

Oliver's feedback (21/07/2022)

  • [x] The logo for Ubuntu Pro Desktop has the old logo, needs updating and maybe have it on the right and a bit bigger so it's more like the live version of the page with the bullets on the left

minkyngkm avatar Jul 22 '22 08:07 minkyngkm