ubuntu.com icon indicating copy to clipboard operation
ubuntu.com copied to clipboard

Open-source package licences page

Open anthonydillon opened this issue 3 years ago • 5 comments

Done

Added an open-source package licences page which loads the data for each release from a static JSON file hosted on assets.

QA

  • VIsit https://ubuntu-com-11604.demos.haus/legal/open-source-licences
  • Check that the first navigation item is selected and the table is populated
  • Select other releases and check the navigation works and the table works when the json is correct.
  • Impish and Focal desktop have broken source data at the moment

anthonydillon avatar May 12 '22 22:05 anthonydillon

Codecov Report

Merging #11604 (9e8ec7c) into main (b5efbde) will decrease coverage by 0.07%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #11604      +/-   ##
==========================================
- Coverage   58.97%   58.89%   -0.08%     
==========================================
  Files         112      112              
  Lines        2625     2625              
  Branches      733      733              
==========================================
- Hits         1548     1546       -2     
- Misses       1014     1015       +1     
- Partials       63       64       +1     
Impacted Files Coverage Δ
...ubscriptions/SubscriptionEdit/SubscriptionEdit.tsx 86.77% <0.00%> (-1.66%) :arrow_down:

codecov[bot] avatar May 12 '22 23:05 codecov[bot]

UX review by @davegoddard42

Desktop

  • Releases are by development codename only, should we include the full name (Ubuntu 22.04 LTS Jammy Jellyfish)?
  • Very long list - could we use pagination?
  • Some basic search or filter would be good - I can take a look if you think it's worth it?
  • If we don't implement filters, we should avoid pagination or make sure to include a “show all” in the Show “x” items drop down. If everything is on the screen the user can Ctrl+F. It’s a technical audience so they’ll likely do that. That could be good enough for MVP.

Mobile

  • The “Toggle side navigation” puts an overlay over the screen, but doesn't offer any options, and I can't get out of it (I'm guessing that's a bug)
  • The cells are cut off - might need to use the .p-table--mobile-card class to make it work? I don't know how many people would look at this on a mobile screen, I'm guessing low, so might be OK for MVP? We should do it if it's not difficult.

anthonydillon avatar May 18 '22 10:05 anthonydillon

@ThinGuy have you had a chance to work on the JSON files? This branch is still waiting for them.

anthonydillon avatar Jul 13 '22 08:07 anthonydillon

@ThinGuy when the new JSON files are ready can you comment here and ping @sowasred2012 so someone on the team and complete and release this project.

Known remaining tasks for the developer that picks this up:

  1. Upload the new JSON files to the asset server
  2. Update the data-file attribute on the navigation items (https://github.com/canonical/ubuntu.com/pull/11604/files#diff-c075bcff4a522ca01a2967e259ef5e8dfa38566aae0f9bb69a87d8db618d75e2R33)
  3. Check the navigation items now that all work and the links to the licences work as expected

anthonydillon avatar Aug 03 '22 10:08 anthonydillon

@ThinGuy are the JSON files ready?

carkod avatar Aug 26 '22 08:08 carkod

Meet Craig and he said he would have the updated files over to me by tomorrow.

anthonydillon avatar Sep 08 '22 15:09 anthonydillon

@anthonydillon did you get the files in the end?

sowasred2012 avatar Sep 13 '22 08:09 sowasred2012

@sowasred2012 nope, chasing again.

anthonydillon avatar Sep 13 '22 09:09 anthonydillon

@ThinGuy thanks for the new data. I have updated them here. Does the demo link in the description look right?

anthonydillon avatar Sep 27 '22 14:09 anthonydillon

Codecov Report

Merging #11604 (8fb20c7) into main (f897886) will increase coverage by 0.29%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #11604      +/-   ##
==========================================
+ Coverage   64.15%   64.44%   +0.29%     
==========================================
  Files         119      119              
  Lines        2636     2652      +16     
  Branches      773      789      +16     
==========================================
+ Hits         1691     1709      +18     
+ Misses        903      902       -1     
+ Partials       42       41       -1     
Impacted Files Coverage Δ
static/js/src/advantage/tests/factories/api.ts 100.00% <0.00%> (ø)
.../src/advantage/react/hooks/useUserSubscriptions.ts 92.85% <0.00%> (ø)
...scriptionDetails/DetailsContent/DetailsContent.tsx 93.33% <0.00%> (+4.44%) :arrow_up:
...ptions/SubscriptionDetails/SubscriptionDetails.tsx 74.22% <0.00%> (+5.09%) :arrow_up:

codecov-commenter avatar Sep 27 '22 14:09 codecov-commenter

Katherine +1'ed via email

anthonydillon avatar Sep 30 '22 12:09 anthonydillon

Good catch @steverydz. Fixed.

anthonydillon avatar Sep 30 '22 14:09 anthonydillon