subiquity
subiquity copied to clipboard
add a s390x-devices section to autoinstall data
@xnox can you take a look at this one?
I think for consistency reasons the section in the autoinstall yaml about ccw devices should be named like in the subiquity UI, so I agree with @xnox that just "zdev" would be a good and coherent naming (of course following the rule that all top level scheme keys are lower-case).
"enable" is obviously the most important option, but I agree that "disable" would be needed too - for the reason @xnox explained above.
I am a bit unsure about "ignore", since I believe there are cases where cio_ignore (to hide ranges of ccw devices aka zdev) needs to be added (usually as kernel parameter) already to the initial install system - like the basic netboot config that one has to put into the parm file for casper). Hence it could just be to late to have it in the autoinstall yaml only, no?
Imho it could be sufficient to "carry forward" a potential cio_ignore kernel arg, that was passed to the initial install system, to the target system too - otherwise people would need to specify cio_ignore twice if doing autoinstalls - at the initial boot as well as in the autoinstall yaml, which would not be ideal.
Just one (relatively new) aspect that I think need to be considered: We recently we noticed that more and more s390x installations are done on systems that do not have any ccw-devices (the z-specific ones 'zdev'), but have PCIe devices instead (mlx5 and NVMe) - LP#1987236. So a check (e.g. using 'lszdev --online' at the end of the installation may lead to an empty result, which would be totally valid - and nothing would need to be added to the autoinstall yaml in such a case.
@mwhudson I agree with all the comments from frank above, but also do not have time to rebase this branch, who is going to work on implementing this?