snapcraft icon indicating copy to clipboard operation
snapcraft copied to clipboard

New kde-neon extension for Qt6 / KF6

Open ScarlettGatelyMoore opened this issue 1 year ago • 1 comments

  • [x ] Have you followed the guidelines for contributing?
  • [ x] Have you signed the CLA?
  • [x ] Have you successfully run tox run -m lint?
  • [ x] Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Tests pass locally.

ScarlettGatelyMoore avatar Mar 26 '24 15:03 ScarlettGatelyMoore

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.57%. Comparing base (6ff73a1) to head (a19d949). Report is 4 commits behind head on main.

:exclamation: Current head a19d949 differs from pull request most recent head c499e62. Consider uploading reports for the commit c499e62 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4698      +/-   ##
==========================================
+ Coverage   89.54%   89.57%   +0.03%     
==========================================
  Files         337      338       +1     
  Lines       22638    22711      +73     
==========================================
+ Hits        20271    20344      +73     
  Misses       2367     2367              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 26 '24 16:03 codecov[bot]

seems like the connection is not happening in the test:

 + '[' 'ERROR: not connected to the kf6-core22 content interface.' = 'hello world' ']'

do we wait for this or manually connect for now? I am ok with either, but I am intending to cut a release tomorrow

sergiusens avatar Apr 08 '24 22:04 sergiusens

seems like the connection is not happening in the test:

 + '[' 'ERROR: not connected to the kf6-core22 content interface.' = 'hello world' ']'

do we wait for this or manually connect for now? I am ok with either, but I am intending to cut a release tomorrow

I am good with manually connect if it's not to late.

ScarlettGatelyMoore avatar Apr 09 '24 12:04 ScarlettGatelyMoore

I just had to add fix 2b439f9e75c1e05e1aa5219a455c8239c3e79f9a to our $HOME ref: https://forum.snapcraft.io/t/setting-home-in-snap-to-user-home-seems-to-cause-all-empty-user-dirs-to-become-broken-symlinks/39463/5

ScarlettGatelyMoore avatar Apr 09 '24 12:04 ScarlettGatelyMoore

@ScarlettGatelyMoore manual connect is good if you can do it now

sergiusens avatar Apr 09 '24 13:04 sergiusens