snapcraft icon indicating copy to clipboard operation
snapcraft copied to clipboard

kde-neon-extension: New content snap for kf5 5.98 and qt 5.15.6

Open ScarlettGatelyMoore opened this issue 2 years ago • 3 comments

  • [x ] Have you followed the guidelines for contributing?
  • [x ] Have you signed the CLA?
  • [ ] Have you successfully run make lint?
  • [ ] Have you successfully run pytest tests/unit?

mypy setup.py snapcraft tests/*.py tests/unit snapcraft/snap_config.py:27: error: Unexpected keyword argument "extra" for "init_subclass" of "object" snapcraft/projects.py:321: error: Unexpected keyword argument "extra" for "init_subclass" of "object" snapcraft/projects.py:641: error: Unexpected keyword argument "extra" for "init_subclass" of "object" Found 3 errors in 2 files (checked 166 source files) make: *** [Makefile:30: test-mypy] Error 1

pytest-3 tests/unit ImportError while loading conftest '/home/scarlett/snapcraft/tests/conftest.py'. tests/conftest.py:22: in from craft_store.auth import MemoryKeyring E ModuleNotFoundError: No module named 'craft_store

ScarlettGatelyMoore avatar Sep 27 '22 15:09 ScarlettGatelyMoore

@ScarlettGatelyMoore The content snap must auto connect for the tests to pass; this needs to be requested on the forums.

ppd avatar Sep 27 '22 16:09 ppd

Signed the CLA, sorry thought I did already

ScarlettGatelyMoore avatar Oct 05 '22 15:10 ScarlettGatelyMoore

Codecov Report

Merging #3925 (df562af) into main (97ab497) will not change coverage. The diff coverage is n/a.

:exclamation: Current head df562af differs from pull request most recent head 43a5d76. Consider uploading reports for the commit 43a5d76 to get more accurate results

@@           Coverage Diff           @@
##             main    #3925   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files          56       56           
  Lines        4154     4154           
=======================================
  Hits         3780     3780           
  Misses        374      374           
Impacted Files Coverage Δ
snapcraft/providers.py 96.55% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Oct 05 '22 15:10 codecov-commenter