snapcraft icon indicating copy to clipboard operation
snapcraft copied to clipboard

requirements: update craft-parts to 1.12.0

Open cmatsuoka opened this issue 2 years ago • 1 comments

Use craft-parts 1.12.0 with changes to the cmake plugin to fix the prefix path and install prefix. This allows libraries built using cmake and staged from a different part to be recognized without defining cmake plugin parameters such as CMAKE_INCLUDE_PATH or CMAKE_LIBRARY_PATH.

LP: #1978859

Signed-off-by: Claudio Matsuoka [email protected]

  • [x] Have you followed the guidelines for contributing?
  • [x] Have you signed the CLA?
  • [ ] Have you successfully run make lint?
  • [ ] Have you successfully run pytest tests/unit?

cmatsuoka avatar Aug 17 '22 19:08 cmatsuoka

Codecov Report

Merging #3878 (8b0c500) into main (b962783) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3878   +/-   ##
=======================================
  Coverage   88.59%   88.59%           
=======================================
  Files          79       79           
  Lines        4842     4842           
=======================================
  Hits         4290     4290           
  Misses        552      552           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 17 '22 20:08 codecov-commenter

Closing in favor of #3879.

cmatsuoka avatar Aug 20 '22 18:08 cmatsuoka