snapcraft icon indicating copy to clipboard operation
snapcraft copied to clipboard

kde extension: new content snap for core20

Open ppd opened this issue 2 years ago • 3 comments

  • [x] Have you followed the guidelines for contributing?
  • [x] Have you signed the CLA?
  • [x] Have you successfully run make lint?
  • [ ] Have you successfully run pytest tests/unit?

See https://github.com/snapcore/snapcraft/pull/3658

ppd avatar Jul 25 '22 11:07 ppd

I think the spread failure is because the content snap hasn't been declared auto-connectable yet.

ppd avatar Jul 25 '22 15:07 ppd

Thanks for this, sorry for the late reply, I was mostly out enjoying some holidays the week prior and just catching up to things. Mind pinging once the snap is auto-connecting for me to retrigger the tests?

sergiusens avatar Aug 02 '22 14:08 sergiusens

The request is here: https://forum.snapcraft.io/t/allow-global-auto-connect-for-kde-frameworks-5-96-qt-5-15-5-core20/31120 I'll ping you when it gets greenlighted.

ppd avatar Aug 10 '22 07:08 ppd

Mind pinging once the snap is auto-connecting for me to retrigger the tests?

@sergiusens Auto-connect has been granted.

ppd avatar Aug 22 '22 07:08 ppd

do you want this released ASAP or do you want it to settle for a bit on edge?

sergiusens avatar Aug 22 '22 18:08 sergiusens

It's a pretty boring update, and we've been publishing the official KDE snaps with it for a while. I'd say: release it soon.

ppd avatar Aug 22 '22 18:08 ppd

Codecov Report

Merging #3846 (4459528) into hotfix/7.1.2 (7612a3a) will decrease coverage by 0.08%. The diff coverage is n/a.

@@               Coverage Diff                @@
##           hotfix/7.1.2    #3846      +/-   ##
================================================
- Coverage         88.06%   87.98%   -0.09%     
================================================
  Files                73       73              
  Lines              4431     4418      -13     
================================================
- Hits               3902     3887      -15     
- Misses              529      531       +2     
Impacted Files Coverage Δ
snapcraft/commands/store/client.py 92.12% <0.00%> (-0.85%) :arrow_down:
snapcraft/elf/_elf_file.py 96.81% <0.00%> (-0.40%) :arrow_down:
snapcraft/meta/extracted_metadata.py 100.00% <0.00%> (ø)
snapcraft/commands/store/constants.py 100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 22 '22 21:08 codecov-commenter