snapcraft
snapcraft copied to clipboard
Delete source bin dir before building the snap (craft-414)
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the CLA?
- [x] Have you successfully run
./runtests.sh static
? - [x] Have you successfully run
./runtests.sh tests/unit
?
Initial fix for https://bugs.launchpad.net/snapcraft/+bug/1936671. Longer term something could be done to filter what files/directories should be copied from the host into the VM. I.e. something like .gitignore
. But this at least resolves the immediate problem until if/when that happens.
Codecov Report
Merging #3567 (18d9366) into master (5060014) will increase coverage by
0.03%
. The diff coverage is83.33%
.
@@ Coverage Diff @@
## master #3567 +/- ##
==========================================
+ Coverage 91.13% 91.17% +0.03%
==========================================
Files 278 278
Lines 19176 19198 +22
==========================================
+ Hits 17477 17504 +27
+ Misses 1699 1694 -5
Impacted Files | Coverage Δ | |
---|---|---|
snapcraft/plugins/v1/crystal.py | 89.13% <83.33%> (-0.87%) |
:arrow_down: |
snapcraft/cli/_options.py | 84.09% <0.00%> (-0.53%) |
:arrow_down: |
snapcraft/plugins/v2/_ros.py | 58.57% <0.00%> (-0.26%) |
:arrow_down: |
snapcraft/plugins/v2/catkin.py | 100.00% <0.00%> (ø) |
|
snapcraft/plugins/v2/colcon.py | 100.00% <0.00%> (ø) |
|
snapcraft/plugins/v2/catkin_tools.py | 100.00% <0.00%> (ø) |
|
snapcraft/internal/repo/snaps.py | 93.27% <0.00%> (+0.03%) |
:arrow_up: |
...apcraft/internal/build_providers/_base_provider.py | 93.05% <0.00%> (+0.08%) |
:arrow_up: |
...t/internal/project_loader/_extensions/ros2_foxy.py | 95.65% <0.00%> (+0.19%) |
:arrow_up: |
...internal/project_loader/_extensions/ros1_noetic.py | 95.45% <0.00%> (+38.31%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5060014...18d9366. Read the comment docs.