snapcraft.io icon indicating copy to clipboard operation
snapcraft.io copied to clipboard

manual review not properly reflected anymore

Open ogra1 opened this issue 5 years ago • 5 comments

Summary

When building a gadget snap, it properly goes into manual review after build and I get a mail telling me about this.

Yet the build.snapcraft.io page tags it with a green "Built and released" label and also tells me I can use sudo snap install --edge <snapname> which is indeed not true until the manual review has passed.

This used to work fine with former gadget snaps.

Process

Build a snap that will require manual review, observe build.snapcraft.io telling you it was released.

Current and expected result

build.snapcraft.io should reflect the actual store status.

ogra1 avatar Aug 02 '19 13:08 ogra1

@ogra1 is this still an issue on snapcraft.io//builds?

Lukewh avatar Jun 23 '20 14:06 Lukewh

i haven't uploaded anything that went into manual review for a while ... will report back if i have one though ...

ogra1 avatar Jun 23 '20 14:06 ogra1

@tbille - could you please check if this is still an issue?

lilyvidenova avatar Oct 28 '20 18:10 lilyvidenova

My guess to test it:

  • Build dummy snap (test-dummy-snap)
  • Sync with the store team to check if they can manually make sure that the snap will require manual review on publish (on staging)
  • On the snap publisher page: connect the build to the GitHub repo
  • Observe what is happening

tbille avatar Oct 29 '20 09:10 tbille

I'd highly appreciate if you could test this when you've got a minute :)

lilyvidenova avatar Oct 29 '20 10:10 lilyvidenova