snapcraft.io icon indicating copy to clipboard operation
snapcraft.io copied to clipboard

"To debug this build" instructions does not apply to foreign arch builds

Open solazio opened this issue 4 years ago • 12 comments

@Lin-Buo-Ren commented on Thu Aug 30 2018

Summary

My snap build only fails on armhf arch. and like to debug it, and I notice that the "To debug this build" section doesn't really comply with this situation as it only deals with the same arch. on the host.

I would expect an additional instruction using the --target-arch option of the snapcraft cleanbuild command.


@solazio commented on Wed Jun 03 2020

We should add this to snapcraft.io Build tab

solazio avatar Jun 03 '20 15:06 solazio

We should add this to snapcraft.io Build tab

solazio avatar Jun 03 '20 15:06 solazio

The new snapcraft.io//builds/ page doesn't have a "To debug this build" section. But we could add a link to https://snapcraft.io/docs/debugging-building-snaps on failed builds? @lilyvidenova what do you think?

Lukewh avatar Jun 23 '20 13:06 Lukewh

image image

Here are two options for where we could place the link, personally I prefer the in-situ one as it'll allow us to link to more detailed help (if we ever get more documentation about it in the future.)

lilyvidenova avatar Oct 27 '20 11:10 lilyvidenova

I prefer the second option as well, however, the links will not be visible on mobile, unless we do something with the table.

image

solazio avatar Oct 27 '20 13:10 solazio

I'm happy with them not be visible on mobile unless you believe someone is likely to try debugging a failed build from their phone?

Could I also add in a couple of drive-by fixes:

  • aligning the last column to the left as it's not purely numerical data
  • on mobile, make enough space for the whole of "Cancelled" and "Released" to be visible, I don't think it should be more than a few extra pixels required to actually show the whole words

lilyvidenova avatar Oct 27 '20 14:10 lilyvidenova

If it helps, simply adding the class p-table--mobile-card to the table element and adding aria-titles attributes to the data we get the following UI on small screens: image

anthonydillon avatar Oct 27 '20 14:10 anthonydillon

Thanks @anthonydillon, we should be using this pattern indeed.

lilyvidenova avatar Oct 28 '20 18:10 lilyvidenova

Just a visual comment, I think maybe the pipe should be #CDCDCD. UX looks good to me.

danielmutis avatar Oct 29 '20 12:10 danielmutis

@danielmutis like this? image

lilyvidenova avatar Oct 29 '20 12:10 lilyvidenova

@lilyvidenova yep that's more consistent with how we use it in CH.

danielmutis avatar Oct 29 '20 12:10 danielmutis

This is ready to be built, adding the label and I guess we should move it back to triaged? @tbille

lilyvidenova avatar Oct 30 '20 09:10 lilyvidenova

I think we shouldn't display the same link every time a build fails on an architecture. I think maybe having an information icon and a tooltip linking to the page would be better; or just a tooltip. @AnnSoMuller @anasereijo

danielmutis avatar Nov 02 '21 14:11 danielmutis