react-components
react-components copied to clipboard
Modal requires title
It would be nice if the Modal didn't require a title when you want to use it to display something like an image.
Vanilla CSS seems to require existence of title, so we would need to update there first.
@hatched is this still relevant? WG couldn't think of a valid use-case to have a modal without a title.
When expanding the bundle/model visualization in the Juju Dashboard we use a modal to house the visualization. In the image below you can see that the title of the modal is unnecessary but we'd have to resort to hacks to hide it so it's been left in.
WG: we should have different flavours:
- True modal, with [ ok ] [ cancel ] no close button
- No title, close button
- Title and close button
- Title and true modal with [ ok ] [ cancel ] and no close button
@clagom reading your comment above but can't find any use-case for the "True modal, with [ ok ] [ cancel ] no close button" which I believe is without a title - are you aware of any examples?
for the context you can see my specs - still WIP
ready for a UX review - @wgx @danielmutis can you have a look, please?
@clagom left you a comment
Thanks @anasereijo, I think it's a good first draft and I saw @wgx reviewed it as well. I would just make sure we are not overlooking use cases and requirements from other products/websites. Did you include the broader team in this sense?
@anasereijo did a few comments, I think there are some changes needed and still an open query from @clagom so we should resolve that before closing this.
I have reviewed the document and I think it's ready. We are only missing visual design.
Seems that in React component title is not required anymore.