react-components icon indicating copy to clipboard operation
react-components copied to clipboard

Modal requires title

Open hatched opened this issue 5 years ago • 9 comments

It would be nice if the Modal didn't require a title when you want to use it to display something like an image.

hatched avatar Jan 30 '20 18:01 hatched

Vanilla CSS seems to require existence of title, so we would need to update there first.

bartaz avatar May 10 '21 14:05 bartaz

@hatched is this still relevant? WG couldn't think of a valid use-case to have a modal without a title.

clagom avatar Jan 12 '22 10:01 clagom

When expanding the bundle/model visualization in the Juju Dashboard we use a modal to house the visualization. In the image below you can see that the title of the modal is unnecessary but we'd have to resort to hacks to hide it so it's been left in.

Screen Shot 2022-01-12 at 9 34 44 AM

hatched avatar Jan 12 '22 15:01 hatched

WG: we should have different flavours:

  • True modal, with [ ok ] [ cancel ] no close button
  • No title, close button
  • Title and close button
  • Title and true modal with [ ok ] [ cancel ] and no close button

clagom avatar Feb 09 '22 10:02 clagom

@clagom reading your comment above but can't find any use-case for the "True modal, with [ ok ] [ cancel ] no close button" which I believe is without a title - are you aware of any examples?

for the context you can see my specs - still WIP

anasereijo avatar Mar 22 '22 17:03 anasereijo

ready for a UX review - @wgx @danielmutis can you have a look, please?

@clagom left you a comment

anasereijo avatar Mar 23 '22 11:03 anasereijo

Thanks @anasereijo, I think it's a good first draft and I saw @wgx reviewed it as well. I would just make sure we are not overlooking use cases and requirements from other products/websites. Did you include the broader team in this sense?

clagom avatar Mar 23 '22 14:03 clagom

@anasereijo did a few comments, I think there are some changes needed and still an open query from @clagom so we should resolve that before closing this.

elioqoshi avatar Mar 31 '22 13:03 elioqoshi

I have reviewed the document and I think it's ready. We are only missing visual design.

danielmutis avatar Apr 11 '22 15:04 danielmutis

Seems that in React component title is not required anymore.

bartaz avatar Sep 30 '24 07:09 bartaz