react-components icon indicating copy to clipboard operation
react-components copied to clipboard

Spinning animation in `ActionButton` ends too late

Open lorumic opened this issue 1 year ago • 2 comments

When using ActionButton with the loading and disabled props, the spinning animation ends later than when the variable regulating the loading behaviour is set to false:

            <ActionButton
              disabled={isLoading}
              loading={isLoading}
              className="u-no-margin--bottom"
              onClick={handleGenerate}
            >
              Request new URL
            </ActionButton>

Peek 2024-07-25 20-30

As can be seen in the screen capture, the cursor gets switched back to the pointer value (= enabled state) while the spinning animation is still showing.

lorumic avatar Jul 25 '24 18:07 lorumic

Not sure if that's the issue with the component itself, or the application, or React rendering. All the button is doing is rendering itself based on props passed. So some more debugging may be needed to understand why they appear to change at different times.

bartaz avatar Sep 30 '24 11:09 bartaz

It's relevant in current architecture (bug in existing component). It's not trivial to reproduce and debug though.

bartaz avatar Oct 24 '24 13:10 bartaz