react-components icon indicating copy to clipboard operation
react-components copied to clipboard

Release notes don't mention all released PRs

Open bartaz opened this issue 1 year ago • 4 comments

It seems that release notes on GH only list a single merged PR, not everything that is part of the release.

For example release 0.50.6: https://github.com/canonical/react-components/releases/tag/v0.50.6

It included at least:

  • https://github.com/canonical/react-components/pull/1052 (that is mentioned)
  • https://github.com/canonical/react-components/pull/1010#issuecomment-2006572458 (that is not mentioned)

Not sure how the current automatic releases with semantic-release work?

bartaz avatar Mar 19 '24 19:03 bartaz

There is some "release notes generator" step, maybe that's where the issue is?

[9:51:30 AM] [semantic-release] › ℹ  The next release version is 0.50.6
[9:51:30 AM] [semantic-release] › ℹ  Start step "generateNotes" of plugin "@semantic-release/release-notes-generator"
[9:51:30 AM] [semantic-release] › ✔  Completed step "generateNotes" of plugin "@semantic-release/release-notes-generator"
[9:51:30 AM] [semantic-release] › ℹ  Start step "prepare" of plugin "@semantic-release/changelog"
[9:51:30 AM] [semantic-release] [@semantic-release/changelog] › ℹ  Create /home/runner/work/react-components/react-components/CHANGELOG.md

bartaz avatar Mar 19 '24 19:03 bartaz

The last release that had multiple PRs was 0.47.3.

The release notes generator was updated in #1030 . This PR bumped the release labeller from v4 to v5, perhaps this caused our issue?

@mas-who do you know anything more about this?

jmuzina avatar May 17 '24 19:05 jmuzina

The last release that had multiple PRs was 0.47.3.

The release notes generator was updated in #1030 . This PR bumped the release labeller from v4 to v5, perhaps this caused our issue?

@mas-who do you know anything more about this?

@jmuzina yes the 0.47.3 release was the last release prior to semantic-release was enabled in #1024. Since semantic-release triggers a release workflow on push to main, it is expected that every merged PR would be a separate release. PR #1030 fixed the issue of pull-request-labeler github action breaking CI and is not related to semantic-release.

There is a guide on how PR titles should be formulated for semantic-release to trigger a release, I think perhaps that is related to the issue @bartaz raised?

@petermakowski any thoughts on this?

mas-who avatar May 20 '24 10:05 mas-who

Not sure how the current automatic releases with semantic-release work?

semantic-release works as expected (but can be changed in the configuration if we choose to do so).

We're using defaults for release notes generator and can be customised as explained here: https://github.com/conventional-changelog/conventional-changelog-config-spec/blob/master/versions/2.0.0/README.md

As we're currently creating a release on every push to main, release notes will always have a single item. Release notes don't mention commits that are not relevant for the consumer of the component library (such as test, refector etc.).

petermakowski avatar Jun 03 '24 09:06 petermakowski

Let's continue using semantic release defaults and see if there are any issues with that in future.

bartaz avatar Sep 26 '24 12:09 bartaz