python-libmaas icon indicating copy to clipboard operation
python-libmaas copied to clipboard

Add skip_bmc_config parameter to create_machine to skip re-config of BMC

Open acormier1 opened this issue 1 year ago • 2 comments

The create_machine API in Maas supports a skip_bmc_config flag. When set to true, this flag skips the bmc config so that a new user is not created. This is a workaround for some lenovo BMC's which have an issue during this provisioning step.

The result in maas when providing this parameter: Screen Shot 2023-10-16 at 5 49 22 PM

acormier1 avatar Oct 16 '23 21:10 acormier1

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.43%. Comparing base (bfe63cc) to head (b29f064).

Files Patch % Lines
maas/client/viscera/machines.py 50.00% 0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
- Coverage   69.43%   69.43%   -0.01%     
==========================================
  Files          76       76              
  Lines        6024     6026       +2     
  Branches     1347     1348       +1     
==========================================
+ Hits         4183     4184       +1     
  Misses       1612     1612              
- Partials      229      230       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 18 '24 18:03 codecov-commenter

Linter isn't happy, could you run tox -e format to fix that?

SK1Y101 avatar Mar 19 '24 23:03 SK1Y101