python-libmaas icon indicating copy to clipboard operation
python-libmaas copied to clipboard

Add read-only 'pod' property to Machine objects

Open ittner opened this issue 5 years ago • 2 comments

This new property allows the client to know in which pod a virtual machine was commissioned (if any). Very useful for building dependency trees between machines.

ittner avatar Sep 18 '20 15:09 ittner

Codecov Report

Merging #245 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   67.98%   67.99%           
=======================================
  Files          70       70           
  Lines        5726     5727    +1     
  Branches      988      988           
=======================================
+ Hits         3893     3894    +1     
  Misses       1610     1610           
  Partials      223      223           
Impacted Files Coverage Δ
maas/client/viscera/machines.py 72.47% <100.00%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 069e758...f3fb3ec. Read the comment docs.

codecov-commenter avatar Sep 18 '20 15:09 codecov-commenter

Codecov Report

Merging #245 (f3fb3ec) into master (575d3f7) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   67.98%   67.99%           
=======================================
  Files          70       70           
  Lines        5726     5727    +1     
  Branches      988      988           
=======================================
+ Hits         3893     3894    +1     
  Misses       1610     1610           
  Partials      223      223           
Impacted Files Coverage Δ
maas/client/viscera/machines.py 72.47% <100.00%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94fe03e...c964794. Read the comment docs.

codecov-io avatar Dec 10 '20 10:12 codecov-io

Codecov Report

Merging #245 (fea8c2c) into master (1ff28d5) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head fea8c2c differs from pull request most recent head 8fd5ccc. Consider uploading reports for the commit 8fd5ccc to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   69.16%   69.17%           
=======================================
  Files          73       73           
  Lines        5958     5959    +1     
  Branches     1336     1336           
=======================================
+ Hits         4121     4122    +1     
  Misses       1607     1607           
  Partials      230      230           
Files Changed Coverage Δ
maas/client/viscera/machines.py 73.08% <100.00%> (+0.08%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 21 '23 09:08 codecov-commenter

LGTM also, merging as tests have passed

SK1Y101 avatar Aug 21 '23 09:08 SK1Y101