multipass icon indicating copy to clipboard operation
multipass copied to clipboard

Az integration

Open andrei-toterman opened this issue 11 months ago • 5 comments

This PR adds implementations for AZs and for the AZ manager, and integrates them in the daemon and the VMs.

There are also many tests file modified, since some APIs changed. The changes in those test files do nothing more than passing in stubs for AZs and the AZ manager where they are required.

MULTI-1870

andrei-toterman avatar Feb 07 '25 14:02 andrei-toterman

Codecov Report

:x: Patch coverage is 87.04453% with 32 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 89.30%. Comparing base (0e5434c) to head (a9be08a). :warning: Report is 3841 commits behind head on availability-zones.

Files with missing lines Patch % Lines
src/daemon/daemon.cpp 73.17% 11 Missing :warning:
...latform/backends/shared/base_availability_zone.cpp 91.07% 5 Missing :warning:
...backends/shared/base_availability_zone_manager.cpp 92.85% 5 Missing :warning:
src/utils/json_utils.cpp 0.00% 5 Missing :warning:
...rc/platform/backends/shared/base_virtual_machine.h 0.00% 4 Missing :warning:
src/daemon/daemon_config.cpp 90.00% 2 Missing :warning:
Additional details and impacted files
@@                  Coverage Diff                   @@
##           availability-zones    #3924      +/-   ##
======================================================
+ Coverage               89.21%   89.30%   +0.09%     
======================================================
  Files                     260      264       +4     
  Lines                   14762    14953     +191     
======================================================
+ Hits                    13170    13354     +184     
- Misses                   1592     1599       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Feb 07 '25 14:02 codecov[bot]

One other thing, is this represented in Jira somehow?

ricab avatar Mar 07 '25 20:03 ricab

@xmkg could you, please, also go over @ricab's comments and see if they were addressed properly, as he is supposed to be a secondary reviewer? :)

andrei-toterman avatar Apr 08 '25 17:04 andrei-toterman

Hey @Sploder12, is this ready for another look?

ricab avatar May 21 '25 11:05 ricab

Hey @Sploder12, is this ready for another look?

I believe so!

Sploder12 avatar May 21 '25 11:05 Sploder12