[build] Use vcpkg to build modules

[townsend2010]

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.60%. Comparing base (dd17d34) to head (185a920).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3215   +/-   ##
=======================================
  Coverage   88.59%   88.60%           
=======================================
  Files         254      254           
  Lines       14086    14086           
=======================================
+ Hits        12480    12481    +1     
+ Misses       1606     1605    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[luis4a0]

Hey @townsend2010! I think we need to address one comment on the private side. And it is possible that its fix go in this public part, so I'm not merging for the time being. Thanks!

[luis4a0]

Hey @townsend2010! I see you force-pushed some changes, but I can't find a way of realizing what changed. In any case, I'll test it functionally. Thanks for this hard work!

[townsend2010]

Hi @luis4a0!

Thanks for reviewing this! The force push basically fixed some code duplication I saw in the top level CMakeLists.txt and a rebase on main. The new change is seen at https://github.com/canonical/multipass/pull/3215/commits/185a920ceb408ce13eaac2ac6848d4f004ac9ff5. This should address the issue you found on the Windows debug build.

[luis4a0]

Thanks! That seems to fix the issue, I'll do some functional testing and we'll be done.

[townsend2010]

Also,

I am a bit concerned by the amount of tweaks which must be done as patches

These are basically taken from the upstream grpc and poco vcpkg ports with the main difference being to only build the libraries we need.

[luis4a0]

These are basically taken from the upstream grpc and poco vcpkg ports with the main difference being to only build the libraries we need.

Perfect, that's what I needed to know to stay calm ;)