multipass icon indicating copy to clipboard operation
multipass copied to clipboard

Published 20 hours ago • verified publisher icon canonical

Recursive transfer dir perms

Open andrei-toterman opened this issue 2 years ago • 1 comments

This PR fixes a bug in the transfer -r command that did not set the copied directories permissions accordingly

andrei-toterman avatar Sep 22 '22 09:09 andrei-toterman

Codecov Report

Merging #2753 (fa9770a) into main (9e3a261) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2753      +/-   ##
==========================================
+ Coverage   87.37%   87.38%   +0.01%     
==========================================
  Files         226      226              
  Lines       11299    11315      +16     
==========================================
+ Hits         9872     9888      +16     
  Misses       1427     1427
Impacted Files Coverage Δ
src/ssh/sftp_client.cpp 96.00% <100.00%> (+0.40%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 22 '22 09:09 codecov[bot]

Hey @andrei-toterman! Looks good, thanks! Just minor remarks inline.

luis4a0 avatar Sep 23 '22 13:09 luis4a0

Hey @luis4a0! Sure, I'll do it, but since I will also add a completion for parents in the other PR, I will do both of them in one commit in the other PR's branch, to avoid dealing with the conflict of doing them separately

andrei-toterman avatar Sep 23 '22 17:09 andrei-toterman

Oops, I said I will add them in the other branch, but added them here. Well, this works as well ¯\_(ツ)_/¯

andrei-toterman avatar Sep 23 '22 17:09 andrei-toterman

No worries, thanks!

luis4a0 avatar Sep 23 '22 18:09 luis4a0

Build failed:

bors[bot] avatar Sep 23 '22 21:09 bors[bot]

bors retry

andrei-toterman avatar Sep 23 '22 21:09 andrei-toterman

Build failed:

bors[bot] avatar Sep 23 '22 23:09 bors[bot]

bors retry

luis4a0 avatar Sep 24 '22 16:09 luis4a0

Build failed:

bors[bot] avatar Sep 24 '22 18:09 bors[bot]

bors retry

luis4a0 avatar Sep 24 '22 21:09 luis4a0

Build succeeded:

bors[bot] avatar Sep 25 '22 00:09 bors[bot]