multipass icon indicating copy to clipboard operation
multipass copied to clipboard

Allow using process substitution for cloud-init file

Open andrei-toterman opened this issue 2 years ago • 1 comments

Passing a process substitution to --cloud-init didn't work since it was checking if it received a regular file, but a process substitution returns a named pipe. Unfortunately QT doesn't have a way to check if a path is a named pipe, but fortunately std::filesystem does.

fix #1589

andrei-toterman avatar Aug 10 '22 15:08 andrei-toterman

Codecov Report

Merging #2700 (12d2bfe) into main (becdbe0) will decrease coverage by 0.10%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2700      +/-   ##
==========================================
- Coverage   86.64%   86.54%   -0.11%     
==========================================
  Files         218      218              
  Lines       10981    10904      -77     
==========================================
- Hits         9515     9437      -78     
- Misses       1466     1467       +1     
Impacted Files Coverage Δ
src/client/cli/cmd/launch.cpp 85.02% <100.00%> (ø)
src/simplestreams/simple_streams_manifest.cpp 94.50% <0.00%> (-2.11%) :arrow_down:
src/daemon/custom_image_host.cpp 97.61% <0.00%> (-0.89%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 10 '22 15:08 codecov[bot]

Build failed:

bors[bot] avatar Aug 12 '22 21:08 bors[bot]

bors retry

andrei-toterman avatar Aug 12 '22 21:08 andrei-toterman

Build failed:

bors[bot] avatar Aug 13 '22 00:08 bors[bot]

bors retry

andrei-toterman avatar Aug 13 '22 05:08 andrei-toterman

Build failed:

bors[bot] avatar Aug 13 '22 07:08 bors[bot]

Again...

bors retry

townsend2010 avatar Aug 15 '22 12:08 townsend2010