multipass icon indicating copy to clipboard operation
multipass copied to clipboard

Fix spinner for non-interactive use

Open ghost opened this issue 5 years ago • 1 comments

Attempting to run non-interactive scripts that run multipass. Logs look like this:

Creating VMs...

                                                                                

                                                                                
Creating test-0  / 
                                                                                

                                                                                
Configuring test-0  /- 
                                                                                

                                                                                
Starting test-0  /-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\ 
                                                                                

                                                                                
Waiting for initialization to complete  /-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\| 
                                                                                
Launched: test-0

                                                                                
Created VM test-0.

This could be resolved by disabling spinners when not running on a live terminal, or via switch.

ghost avatar May 15 '20 19:05 ghost

Thanks @chornlgscout, we already modify some things when non-interactive, you're right we should also change how we're doing spinners in that case.

Saviq avatar May 16 '20 09:05 Saviq