microceph icon indicating copy to clipboard operation
microceph copied to clipboard

Update mount-block-device.rst

Open ismailkayi opened this issue 1 year ago • 2 comments

1- Missing sudo command added. (https://github.com/canonical/microceph/issues/404) 2 - Steps have been added for the issue : https://github.com/canonical/microceph/issues/406

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x] Documentation update (Doc only change)

How Has This Been Tested?

NOTE: All functional changes should accompany corresponding tests (unit tests, functional tests etc).

Please describe the addition/modification of tests done to verify this change. Please also list any relevant details for your test configuration.

Contributor's Checklist

Please check that you have:

  • [x] updated the user documentation with corresponding changes.

ismailkayi avatar Aug 29 '24 07:08 ismailkayi

lgtm, although I'm wondering if it wouldn't also be possible to specify the ceph.conf path to the specific commands instead of using a symbolic link

Yes we can, infact that is what the document does at the moment. I still feel that having a symlink there could be good. (we have plans to do the symlinking automatically from inside microceph soon).

UtkarshBhatthere avatar Sep 03 '24 12:09 UtkarshBhatthere

@ismailkayi please sign your commits using a GPG key. ref. This is required for all contributions to be accepted for MicroCeph (check failing CI test)

UtkarshBhatthere avatar Sep 03 '24 12:09 UtkarshBhatthere