lxd icon indicating copy to clipboard operation
lxd copied to clipboard

Storage volume/instance snapshot edit restriction

Open tugbataluy opened this issue 1 month ago • 4 comments

Checklist

What Does This PR Do?

When editing a Storage Volume snapshot, modifications to writable fields are saved successfully. However, changes to read-only fields are simply ignored without notification, which can be confusing for users, as noted in issue #14423.

The same situation applies to instance snapshots. This PR ensures that if a snapshot is present within the two edit commands related to this situation, input validation is performed, and if a non-editable property is modified, an error is returned to the user.

Fixes #14423

tugbataluy avatar Nov 25 '25 16:11 tugbataluy

the operation silently fails without providing any feedback to the user.

It doesn't silently fail, just the read-only fields are not modified, but the writable ones are still persisted.

tomponline avatar Dec 05 '25 15:12 tomponline

@tugbataluy the tests are failing and this needs a rebase to be mergeable as other conflicting PRs have been merged in the interim.

You can open a draft PR, check the tests pass, before promoting to "reviewable".

tomponline avatar Dec 09 '25 08:12 tomponline

Please rebase

tomponline avatar Dec 11 '25 15:12 tomponline

@tugbataluy also needs a rebase now that we've removed translations.

tomponline avatar Dec 12 '25 12:12 tomponline