lxd icon indicating copy to clipboard operation
lxd copied to clipboard

Add support for fetching images across all projects

Open kadinsayani opened this issue 1 year ago • 1 comments

Resolves https://github.com/canonical/lxd/issues/14126.

This PR adds support for fetching images across all projects by adding a query parameter all-projects and doGetImagesAllProjects(). I've also added a client function to lxd_images.go if we ever want to use this feature in the LXD CLI.

kadinsayani avatar Oct 10 '24 23:10 kadinsayani

Heads up @mionaalex - the "Documentation" label was applied to this issue.

github-actions[bot] avatar Oct 10 '24 23:10 github-actions[bot]

This PR should be good to go. It adds support for the --all-projects flag when running lxc image list. I'm planning to open separate PR's for --all-projects support for network zones, profiles, networks, network-acls, and storage buckets (Incus cherry picks).

kadinsayani avatar Nov 06 '24 14:11 kadinsayani

Just a few nits that should be easy to fix :)

Thanks for the review @markylaing :) I think I've addressed everything now.

kadinsayani avatar Nov 11 '24 14:11 kadinsayani

Just a couple of last bits. Thanks :)

Should be good to go, thanks!

kadinsayani avatar Nov 12 '24 16:11 kadinsayani

Rebased and good to go 👍

kadinsayani avatar Nov 21 '24 22:11 kadinsayani

There are no tests, we especially need tests to check access control of images.

Tests added! 😄

kadinsayani avatar Nov 22 '24 20:11 kadinsayani