Follow-up fixes related to NVIDIA CDI

Open gabrielmougard opened this issue 1 year ago • 1 comments

This tracks all the future improvements related to GPU passthrough using NVIDIA CDI introduced with https://github.com/canonical/lxd/pull/13562 :

Once https://github.com/NVIDIA/nvidia-container-toolkit/issues/671 gets solved, we can remove the need for evaluatedHostPath, err := filepath.EvalSymlinks(mount.HostPath) in https://github.com/canonical/lxd/pull/13562#discussion_r1701610711
https://github.com/canonical/lxd/pull/13562#discussion_r1701620261
When fillMissingInfo is public at https://github.com/cncf-tags/container-device-interface/blob/main/pkg/cdi/container-edits_unix.go#L60, we can rely on it (see https://github.com/canonical/lxd/pull/13562#discussion_r1734340099)
https://github.com/canonical/lxd/pull/13562#discussion_r1734356134

Aug 28 '24 14:08 gabrielmougard

Given https://nvidia.custhelp.com/app/answers/detail/a_id/5582 and https://nvidia.custhelp.com/app/answers/detail/a_id/5582 we should also seek to invoke the CDI tool with an AppArmor profile.

Sep 30 '24 12:09 tomponline