canonical
lxc: allow creation of various resources from YAML (from Incus)
cherry-picked from: https://github.com/lxc/incus/pull/786 cherry-picked from: https://github.com/lxc/incus/pull/782 cherry-picked from: https://github.com/lxc/incus/pull/778 cherry-picked from: https://github.com/lxc/incus/pull/775 cherry-picked from: https://github.com/lxc/incus/pull/767 cherry-picked from: https://github.com/lxc/incus/pull/863 cherry-picked from: https://github.com/lxc/incus/pull/864 cherry-picked from: https://github.com/lxc/incus/pull/891
I guess the cluster test suite iis broken because of the new dqlite ppa? The rest of the tests seem ok.
@gabrielmougard before I go any further, please can you go through this PR (and your earlier related ones) and double check that the whole of the
Putdata being read in is actually being applied, and that the name of the resource isn't being overridden from stdin too, as it looks like at least some of these cherry-picks are only taking the Config from the Put structure and not things like Description.
It should be fixed now. I also opened this related issue: https://github.com/canonical/lxd/issues/14011
@gabrielmougard did you also review your earlier PRs https://github.com/canonical/lxd/pulls?q=is%3Apr+is%3Aclosed+author%3Agabrielmougard+lxc for similar issues that I missed before?
@gabrielmougard did you also review your earlier PRs https://github.com/canonical/lxd/pulls?q=is%3Apr+is%3Aclosed+author%3Agabrielmougard+lxc for similar issues that I missed before?
@tomponline After reading these past PRs, I noticed I missed adding a description field in the test commit of #13923 and check it has been applied... Shall I fix this in this PR? The rest of the past PRs look fine to me.
@tomponline After reading these past PRs, I noticed I missed adding a
descriptionfield in the test commit of #13923 and check it has been applied... Shall I fix this in this PR? The rest of the past PRs look fine to me.
Yes please