lxd icon indicating copy to clipboard operation
lxd copied to clipboard
verified publisher icon canonical

VM: Correct QEMU device ID max length

Open hamistao opened this issue 1 year ago • 3 comments

I don't think this is currently causing any bugs, but the correct limit for QEMU IDs is 63, not 64. If longer than that, QEMU truncates the ID internally.

hamistao avatar Jun 26 '24 22:06 hamistao

@hamistao to be comfortable with this change please can you double check that the /dev/disk/by-id names do not change for block disk device passthroughs. Cheers

tomponline avatar Jun 27 '24 09:06 tomponline

I beleive this is safe to merge. Both entries for the device on /dev/disk/by-id are generated from the serial name (and not the device ID), so this could not affect them

hamistao avatar Jun 27 '24 16:06 hamistao

I beleive this is safe to merge. Both entries for the device on /dev/disk/by-id are generated from the block node name (and not the device ID), so this could not affect them

Ok cool ill wait for the lxd-ci disk by id tests to be merged and passed, then merge this to check for regressions

tomponline avatar Jun 27 '24 17:06 tomponline