lxd icon indicating copy to clipboard operation
lxd copied to clipboard

Published 20 hours ago • verified publisher icon canonical

API: Unembed Put structs from Get structs

Open MusicDin opened this issue 1 year ago • 3 comments

Unembed Put structs from Get structs.

Fixes https://github.com/canonical/lxd/issues/12993

MusicDin avatar Mar 04 '24 15:03 MusicDin

@MusicDin please may you rebase on https://github.com/canonical/lxd/pull/13045 as i intend to merge that one before this and it contains some API struct changes.

tomponline avatar Mar 06 '24 14:03 tomponline

@MusicDin ive merged https://github.com/canonical/lxd/pull/13045 so can be rebased now.

tomponline avatar Mar 06 '24 16:03 tomponline

Looks good, just a few places that are removing white space from queries unrelated to commit message.

Fixed.

MusicDin avatar Mar 06 '24 17:03 MusicDin

Seems I've broke something.. Looking into it.

MusicDin avatar Mar 06 '24 20:03 MusicDin

@MusicDin it looks fixed now, what was the issue? Thanks

tomponline avatar Mar 07 '24 08:03 tomponline

Yep. I accidentally unset Driver field in StoragePool struct (in lxd/api_internal_recover) when changing to SetWritable().

MusicDin avatar Mar 07 '24 08:03 MusicDin

Thanks!

tomponline avatar Mar 07 '24 08:03 tomponline