lxd-ui icon indicating copy to clipboard operation
lxd-ui copied to clipboard

Update to use Application Layout components from React Components.

Open huwshimi opened this issue 9 months ago • 3 comments

Done

  • [List of work items including drive-bys]

Fixes [list issues/bugs if needed]

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • [List the steps to QA the new feature(s) or prove that a bug has been resolved]

Screenshots

[if relevant, include a screenshot or screen capture]

huwshimi avatar May 14 '24 06:05 huwshimi

These components are now available in react-components: https://canonical.github.io/react-components/?path=/docs/components-applicationlayout--docs.

There are some small changes since this PR was created, but if someone would like to take over this PR that would be great!

huwshimi avatar Jul 02 '24 23:07 huwshimi

These components are now available in react-components: https://canonical.github.io/react-components/?path=/docs/components-applicationlayout--docs.

There are some small changes since this PR was created, but if someone would like to take over this PR that would be great!

Thanks for the update, we'll pick this up in the near future. Might be something for @Kxiru

edlerd avatar Jul 03 '24 06:07 edlerd

Thank you @huwshimi for your implementation and suggestions. This was a great PR to use for reference and we have now successfully incorporated some Application Layout components into LXD-UI. I will now close this PR. Thanks again!

Kxiru avatar Sep 04 '24 15:09 Kxiru