canonical
Fix some non-Linux test failures
Proposed Commit Message
Fix some non-Linux test failures
At least partially fixes GH-5336
Additional Context
With these changes (and changes to the default TMPDIR), tests pass for me on a Mac. This PR contains multiple commits and each commit should be independently reviewable. I'll leave it up to whoever merges to decide if they want to squash or not.
Test Steps
Merge type
- [x] Squash merge using "Proposed Commit Message"
- [ ] Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)
Update: we're looking into doing the company-wide CLA, so it may be a while
Update: we're looking into doing the company-wide CLA, so it may be a while
Thanks for the update. Keep us posted!
Update: still waiting on CLA. Mostly just commenting to stop the stale checker from flagging this again 😄
CLA has been signed on our end, so now just waiting for whatever magic needs to happen on the Canonical side for the CLA checker to be updated.
CLA has been signed on our end, so now just waiting for whatever magic needs to happen on the Canonical side for the CLA checker to be updated.
Woo hoo! Welcome back!
@TheRealFalcon in prepartion for landing, a couple of hacktoberfest commits landed dropping tests/helpers.py::TestCase which resulted in a merge conflict. I'll make sure I touch base with Canonical CLA folks to ensure the CLA signing is permitted now for your company so we can clear the CI workflow.
Noted, I'll do the rebase once the CLA checker says I'm good. I've just been manually curling it to see.
Thanks!
the CLA job hasn't passed yet
Still waiting on this unfortunately. I believe we submitted it a few weeks ago. Is there something stuck on the Canonical side?
Thanks!
the CLA job hasn't passed yet
Still waiting on this unfortunately. I believe we submitted it a few weeks ago. Is there something stuck on the Canonical side?
I've copied internal folks here saying we're blocked with "external" contributors having signed the CLA. My visibility here is that legal has been asked about this directly and they CLA-folks are awaiting a response. I'll bump this topic again so we can unblock.
sigh looks like there's still more to sort on our end. Commenting again to keep the auto-closer quiet