cloud-init icon indicating copy to clipboard operation
cloud-init copied to clipboard

docs(mounts): Correct fs-freq reference to fs_freq

Open ibrahim-mojalled opened this issue 6 months ago • 2 comments

Corrects the spelling of the fstab 'fs_freq' field from 'fs-freq' to 'fs_freq' in documentation, examples, and comments.

Closes #GH-6210

Proposed Commit Message

docs(mounts): Correct fs-freq reference to fs_freq (#6262)

Corrects the spelling of the fstab 'fs_freq' field from 'fs-freq'
to 'fs_freq' in documentation, examples, and comments.

Fixes GH-6210

Additional Context

Test Steps

Merge type

  • [x] Squash merge using "Proposed Commit Message"
  • [ ] Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

ibrahim-mojalled avatar Jun 12 '25 09:06 ibrahim-mojalled

@ibrahim-mojalled thank you much for improving cloud-init. I confirm this is the correct fix and we would like to include it in upstream cloud-init. To allow us to use your changset, would you please sign this project's contributor license agreement at https://ubuntu.com/legal/contributors? Once the cla-check passes, we can merge your changeset.
Many thanks!

Also in the commit message footer we typically use the format to allow our tooling to best represent release fixes using a project-standard convention:

Fixes GH-6210

We can fix your commit message upon merge if you like, the only thing we'd need though is that CLA signed at the link above.

blackboxsw avatar Jun 24 '25 17:06 blackboxsw

@blackboxsw I signed the CLA before and I rechecked through the link you provided and it shows that "The provided email address is already associated with a CLA".

ibrahim-mojalled avatar Jun 25 '25 12:06 ibrahim-mojalled

LGTM, thanks.

But the CLA seems to be not signed by: https://github.com/canonical/cloud-init/actions/runs/15607390546/job/45054285701#step:2:10.

Are you, @ibrahim-mojalled, sure that you have signed it with the email [email protected]?

aciba90 avatar Jun 30 '25 13:06 aciba90

@aciba90 I updated the git config email address, the problem should be fixed now hopefully.

ibrahim-mojalled avatar Jun 30 '25 17:06 ibrahim-mojalled