cloud-init icon indicating copy to clipboard operation
cloud-init copied to clipboard

ubuntu/focal/24.2: Patch out ConditionEnvironment key in systemd/cloud-init-hotplugd.{service,socket}

Open aciba90 opened this issue 1 year ago • 3 comments

Patch out the ConditionEnvironment keys introduced in https://github.com/canonical/cloud-init/commit/57c022d652abf53854546af5abcfffdef7fa3c6f for focal as systemd<246 issues warnings about that unknown key.

Probably place it within the patch introduce it in: https://github.com/canonical/cloud-init/pull/5312

To do this, we need to perform a new upstream snapshot in focal to include the tip of main there.

aciba90 avatar Jun 13 '24 10:06 aciba90

@aciba90 since upstream release of 24.2 will be cut and our SRU will pull from upstream/ubuntu/focal:debian/patches/drop-unsupported-systemd-condition-environment.patch is there anything additional that you suggest we do here?

I think this is already covered by our typical SRU process will be to cut/tag a upstream/24.2 tag from current tip of main. Then any SRU's to stable Ubuntu releases will be pulled from upstream/ubuntu/(focal|jammy|noble|...) which contain the expected quilt patch reverting the ConditionEnvironment variable.

Was this an issue maybe to just to track that we have a fix already queued for the upcoming SRU release of 24.2?

blackboxsw avatar Jun 20 '24 23:06 blackboxsw

https://github.com/canonical/cloud-init/commit/57c022d652abf53854546af5abcfffdef7fa3c6f introduced the aforementioned key in https://github.com/canonical/cloud-init/blob/main/systemd/cloud-init-hotplugd.service and https://github.com/canonical/cloud-init/blob/main/systemd/cloud-init-hotplugd.socket. This is issue is tracking that work.

aciba90 avatar Jun 25 '24 06:06 aciba90

@aciba90 PR #5448 up to resolve this issue on focal.

blackboxsw avatar Jun 25 '24 18:06 blackboxsw

Fixed in release 24.2.

holmanb avatar Jul 03 '24 18:07 holmanb