cloud-init icon indicating copy to clipboard operation
cloud-init copied to clipboard

Ensure bond property name formatting matches schema definition

Open jcmoore3 opened this issue 1 year ago • 3 comments

Ensure the bond properties match formatting of within the cloudinit network v1 schema

Fixes #5366

Proposed Commit Message

fix: Ensure bond property name formatting matches schema definition

The cloud-init network config version 1 schema defines the bond
properties with underscores, prepended with 'bond-'. This change
ensures consistency with the schema for the bond property names.

Fixes GH-5366

Additional Context

Test Steps

Checklist

Merge type

  • [x] Squash merge using "Proposed Commit Message"
  • [ ] Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

jcmoore3 avatar Jun 06 '24 19:06 jcmoore3

Thank you for contributing to cloud-init! Can you add some notes on the testing you did to validate that it fixed the bug in question and sign the CLA?

https://cloudinit.readthedocs.io/en/latest/development/first_PR.html#sign-the-cla

catmsred avatar Jun 11 '24 13:06 catmsred

Apologies that the CLA is taking so long. This needs to go through my company's internal open source approval process. I do not anticipate any issues, it just takes time. I'm hoping to have final internal approval this week.

jcmoore3 avatar Jun 25 '24 12:06 jcmoore3

@catmsred - CLA signed, please let me know if anything else is required to get this moving. Change to github-cla-signers is in PR #5369.

jcmoore3 avatar Jun 27 '24 15:06 jcmoore3

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

github-actions[bot] avatar Aug 06 '24 00:08 github-actions[bot]