Fix ssh key permissions for redhat distros where 'ssh_keys' group is absent

[ani-sinha]

Proposed Commit Message

Fedora core 38 and above, centos 10 stream and all distributions derived from them do not have the group 'ssh_keys'. Please see the fedora rawhide change https://src.fedoraproject.org/rpms/openssh/c/7a21555354a2c5e724aa4c287b640c24bf108780?branch=rawhide In those distributions, openssh versions are 9 and above. The private key permissions are set as 0o600 and the public key permissions are set as 0o644 from sshd-keygen utility. The 'root' group owns the keys. Please see https://src.fedoraproject.org/rpms/openssh/c/b615362fd0b4da657d624571441cb74983de6e3f?branch=rawhide

In older releases where 'ssh_keys' group is present, the private key permissions are set as 0o640. Public key permissions are 0o644. These releases have openssh version less than 9.

Since cloud-init generates the keys and not sshd-genkey utility, permissions must be set accordingly for cloud-init generated public and private keys in all cases. This includes cases where 'ssh_keys' group is absent. This change fixes this. The code has been reworked a little bit so as to simplify things. Unit tests have been adjusted accordingly.

Checklist

• [x ] My code follows the process laid out in the documentation
• [ x] I have updated or added any unit tests accordingly
• [ ] I have updated or added any documentation accordingly

Merge type

• [x] Squash merge using "Proposed Commit Message"
• [ ] Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)