cloud-init icon indicating copy to clipboard operation
cloud-init copied to clipboard

d/control: remove netifaces [noble]

Open catmsred opened this issue 11 months ago • 5 comments

netifaces is being removed from tip of main in GH-4634. This change also removes it from the Ubuntu packaging.

Test Steps

Untested

Checklist

Merge type

  • [ ] Squash merge using "Proposed Commit Message"
  • [ ] Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

catmsred avatar Mar 04 '24 18:03 catmsred

Setting as WIP until GH-4634 lands

catmsred avatar Mar 04 '24 18:03 catmsred

@catmsred this needs to be refreshed against the recent updates to ubuntu/devel

holmanb avatar Mar 05 '24 18:03 holmanb

Status: successful
Version: 24.2~1g621c522c-0ubuntu1
--------------------------------------------------------------------------------
Finished at 2024-03-09T19:57:27Z
Build needed 00:02:15, 27684k disk space

@catmsred Nice, that looks much better!

Question: How did you end up with b392d725d3528fe0b2c8cf1403c3d62547aecc3c and b60e4c184b8c25f8c26f67eb0ed7ba87f9a688c6 in the middle of the merge commits? Maybe a manual rebase after the snapshot? This technically works, but normally I don't think we insert commits into the middle of a block of commits introduced by a merge. Would you mind rebasing those commits to the end of the this PR? Once you do, I think this is ready to merge!

holmanb avatar Mar 09 '24 19:03 holmanb

Question: How did you end up with https://github.com/canonical/cloud-init/commit/b392d725d3528fe0b2c8cf1403c3d62547aecc3c and https://github.com/canonical/cloud-init/commit/b60e4c184b8c25f8c26f67eb0ed7ba87f9a688c6 in the middle of the merge commits? Maybe a manual rebase after the snapshot? This technically works, but normally I don't think we insert commits into the middle of a block of commits introduced by a merge. Would you mind rebasing those commits to the end of the this PR? Once you do, I think this is ready to merge!

I have no idea how that happened, to be honest. I ran new_upstream_snapshot.py uss-tableflip and this was the result. I will rebase to fix that.

catmsred avatar Mar 11 '24 13:03 catmsred

Linkcheck failure is not related to this code

catmsred avatar Mar 11 '24 17:03 catmsred

@catmsred , sorry for the churn on this one. Since we've already independently merged an upstream snapshot for this branch, I'm closing this PR in favor of https://github.com/canonical/cloud-init/pull/5081 .

TheRealFalcon avatar Mar 20 '24 20:03 TheRealFalcon