canonical
feat(azurelinux): Add new distro 'azurelinux' for Microsoft Azure Linux.
Proposed Commit Message
This adds support for the new (renamed) distro 'Azure Linux'.
Azure Linux is the renamed next version of the existing 'Mariner'
distro. It is similar to the 'Mariner' distro but changes the base
inherited Distro() class.
Additional Context
Checklist
- [x] My code follows the process laid out in the documentation
- [x] I have updated or added any unit tests accordingly
- [x] I have updated or added any documentation accordingly
Merge type
- [x] Squash merge using "Proposed Commit Message"
- [ ] Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)
@ddstreetmicrosoft Thanks for this PR. Does this mean that the Mariner datasource is no longer relevant? Should we remove it at some point?
If you check the CI runs, you'll see there's a few lint failures that need to be fixed before we can merge this.
Additionally, before we can accept your change, you need to sign the CLA and add your Github username (alphabetically) to the cla signers file . The full details are described in the last bullet point of the documentation . It looks like you may have already signed the CLA under a different github name, so if you're using two (ddstreet and ddstreetmicrosoft), please add them both the signers file.
LGTM. Looks like black needs to be run against some of the files. Is there need to keep Mariner after this change?
@ddstreetmicrosoft Thanks for this PR. Does this mean that the Mariner datasource is no longer relevant? Should we remove it at some point?
LGTM. Looks like black needs to be run against some of the files. Is there need to keep Mariner after this change?
While the Mariner naming is currently still a supported release, that name will retire at the end of its support lifetime; I could update this PR to completely switch over (i.e. remove 'Mariner' while adding 'Azure Linux') if you think that's appropriate? Since the Mariner release is in a stable period (and shouldn't be updating its cloud-init) there shouldn't be any reason to need to keep it in the upstream code here.
Alternately, I could open a separate PR to remove 'Mariner', either soon or closer to when it goes EOL (which will be late this year at the earliest, more likely sometime next year).
If you check the CI runs, you'll see there's a few lint failures that need to be fixed before we can merge this.
ack, thanks, i ran tox -e do_format and added the change, and a full tox run succeeded, so should be ok now i hope.
Additionally, before we can accept your change, you need to sign the CLA and add your Github username (alphabetically) to the cla signers file . The full details are described in the last bullet point of the documentation . It looks like you may have already signed the CLA under a different github name, so if you're using two (
ddstreetandddstreetmicrosoft), please add them both the signers file.
i signed the CLA and included both my github usernames (ddstreet and ddstreetmicrosoft) in the signers file, in this pr.
Alternately, I could open a separate PR to remove 'Mariner', either soon or closer to when it goes EOL (which will be late this year at the earliest, more likely sometime next year).
Yes, a separate PR sounds good. If there is truly no need for the upstream code anymore, then soon is fine, but there is also no harm in keeping it here for the time being.
The 3.13 test failure is unrelated and being addressed in https://github.com/canonical/cloud-init/pull/5052 . If everything else passes I'll merge as-is.