Bring back ds-identify fix

[holmanb]

Additional Context

Originally proposed by @smoser, then reverted due to a reported bug that it introduced. This brings back the original proposal by Scott plus the fixes required to resolve the issues it introduced. Also makes some minor shellcheck and test changes.

Merge type

• [ ] Squash merge using "Proposed Commit Message"
• [x] Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

[github-actions[bot]]

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

[github-actions[bot]]

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

[github-actions[bot]]

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

[holmanb]

@TheRealFalcon regarding your change request I started to make the tool stricter, and I realized that there were some pretty glaring errors in the previous implementation. The biggest issues were assuming that the user would only use double quotes, and various assumptions about whitespace location and type.

Therefore, in addition to making the check stricter, I also fixed these issues and added a slew of tests to verify correct behavior.

[holmanb]

LGTM! Really nice cleanup!

Thanks!

I just force pushed to merge a couple of related commits and update some commit wording. Will merge once tests pass.