cloud-init icon indicating copy to clipboard operation
cloud-init copied to clipboard

setup.py is not PEP517 compliant

Open ubuntu-server-builder opened this issue 2 years ago • 5 comments

This bug was originally filed in Launchpad as LP: #1978328

Launchpad details
affected_projects = []
assignee = None
assignee_name = None
date_closed = None
date_created = 2022-06-10T15:57:48.990151+00:00
date_fix_committed = None
date_fix_released = None
id = 1978328
importance = medium
is_complete = False
lp_url = https://bugs.launchpad.net/cloud-init/+bug/1978328
milestone = None
owner = holmanb
owner_name = Brett Holman
private = False
status = triaged
submitter = holmanb
submitter_name = Brett Holman
tags = []
duplicates = []

Launchpad user Brett Holman(holmanb) wrote on 2022-06-10T15:57:48.990151+00:00

A bug[1] was filed downstream for this, and reported upstream in #cloud-init IRC by Sam (Gentoo maintainer).

This causes build failure on Gentoo/OpenRC, which is carrying a downstream workaround[2] for now.

It looks like the upstream installation method for init scripts and additional bits (non-Python files at all) isn't compatible with PEP517, so PEP517 installs are broken right now.

PEP517 with the wheel spec doesn't have a good way of installing data files.

[1] https://bugs.gentoo.org/850628 [2] https://github.com/gentoo/gentoo/commit/44cfdb3c49f7ebce1e66324ad5ac68285d8d08bb

ubuntu-server-builder avatar May 12 '23 17:05 ubuntu-server-builder

Launchpad user Brett Holman(holmanb) wrote on 2022-06-11T04:47:03.353253+00:00

Launchpad attachments: good.log

ubuntu-server-builder avatar May 12 '23 17:05 ubuntu-server-builder

Launchpad user Brett Holman(holmanb) wrote on 2022-06-11T04:47:30.949233+00:00

Launchpad attachments: bad.log

ubuntu-server-builder avatar May 12 '23 17:05 ubuntu-server-builder

Launchpad user Brett Holman(holmanb) wrote on 2022-06-11T04:53:08.624166+00:00

From Sam, after sharing the logs:

There's a hint of it at the very end because you see the chmod fails (there was a missing die in the ebuild).

run:

python -m build -C--init-system=openrc # no, that's not a typo, no space after 'C' python3 -m installer dist/cloud*.whl --destdir=/tmp/foo

/tmp/foo/* only contains the usr/bin and usr/lib/*

ubuntu-server-builder avatar May 12 '23 17:05 ubuntu-server-builder

looks like this is still an issue :(

may be removed from gentoo because of it

https://bugs.gentoo.org/909872

prometheanfire avatar Mar 08 '24 04:03 prometheanfire

@prometheanfire thanks for the ping

I was just working on the upstream support for this today, will try to get this fixed asap.

holmanb avatar Mar 08 '24 06:03 holmanb