canonical.com icon indicating copy to clipboard operation
canonical.com copied to clipboard

refactor: update maas feature page with Vanilla improvements

Open huwshimi opened this issue 5 months ago • 2 comments

Done

  • Updated the MAAS features page now that my PRs have been released in Vanilla.

QA

  • Go to /maas/features.
  • Check that the page is unchanged except that the following issue has been fixed: Current:
Screenshot 2025-11-26 at 1 13 10 pm

Fixed:

Screenshot 2025-11-26 at 1 13 17 pm

huwshimi avatar Nov 26 '25 05:11 huwshimi

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 78.11%. Comparing base (30b9292) to head (971056d). :warning: Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2088   +/-   ##
=======================================
  Coverage   78.11%   78.11%           
=======================================
  Files          16       16           
  Lines        1695     1695           
=======================================
  Hits         1324     1324           
  Misses        371      371           
Flag Coverage Δ
python 78.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 26 '25 06:11 codecov[bot]

Please fix linting check and I have re-ran the percy check

immortalcodes avatar Jan 19 '26 07:01 immortalcodes

Please fix linting check and I have re-ran the percy check

Any ideas why the python lint is failing? I haven't modified those files and the lint passes locally. I've rebased on the latest main with no change.

huwshimi avatar Jan 19 '26 22:01 huwshimi

image Seems odd since you haven't changed any python files, but you can format files using `dotrun format-python`

immortalcodes avatar Jan 20 '26 09:01 immortalcodes

@huwshimi I pushed a fix for this on the main branch You can rebase/merge to get the fix That should unblock this PR

Onibenjo avatar Jan 22 '26 10:01 Onibenjo

@huwshimi I pushed a fix for this on the main branch You can rebase/merge to get the fix That should unblock this PR

@Onibenjo Thanks so much!

huwshimi avatar Jan 26 '26 22:01 huwshimi