canonical.com icon indicating copy to clipboard operation
canonical.com copied to clipboard

Valkey: Page update.

Open jpmartinspt opened this issue 9 months ago • 9 comments

Done

New what-is-valkey page.

QA

Check page matches the design linked on the ticket and the copydoc.

Fixes https://warthogs.atlassian.net/browse/WD-19382?focusedCommentId=700114

jpmartinspt avatar Mar 21 '25 19:03 jpmartinspt

Thanks @jpmartinspt !

Feedback:

For the spotlight section:

  • [x] "Why choose Valkey" should have regular stying (black) rather than be muted
  • [x] I believe there should be a question mark at the end too, looking at the copydoc (cc: @Sophie-32 @eliman11)

For "How companies use Valkey?":

  • [x] Could you wrap the h2 in a shallow?
  • [x] Pls hide the images here on mobile view

For "How does Valkey work?"

  • [x] The hrs above each of the subsections w/images should be muted (i.e. above the sections "A single valkey...", "Replication, as shown...", and "The Valkey Cluster..."

For "Choose the right database..."

  • [x] The table footnote seems to be misaligned; could it start at 50% of the page width pls?

For "Enterprise Valkey offered...":

  • [x] The second column should also start at 50% of the page width
  • [x] All of the hrs in this section, aside from the full-width one at the top, should be muted
  • [x] Could you wrap each subsection (i.e. "Valkey for Linux VMs", "Valkey OCI-compliant...", etc.) in a shallow?
  • [x] I also made a small design change here (see Figma), where I moved the "incl. in Ubuntu Pro + Support" text to sit right under the h5 text, with h5 muted styling

For the disclaimer section:

  • [x] Bottom padding should be deep

mattea-turic avatar Mar 24 '25 12:03 mattea-turic

For "How does Valkey work?"

 The hrs above each of the subsections w/images should be muted (i.e. above the sections "A single valkey...", "Replication, as shown...", and "The Valkey Cluster..."

What are the HRs in this sections? I only see paragraphs.

@mattea-turic

jpmartinspt avatar Mar 24 '25 15:03 jpmartinspt

What are the HRs in this sections? I only see paragraphs.

@jpmartinspt, sorry if I wasn't clear; I meant the rules

mattea-turic avatar Mar 24 '25 16:03 mattea-turic

Hey @jpmartinspt , the link doesn't seem to be working for me

mattea-turic avatar Mar 27 '25 09:03 mattea-turic

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.69%. Comparing base (387177f) to head (e6cb836). Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1614      +/-   ##
==========================================
- Coverage   71.90%   71.69%   -0.21%     
==========================================
  Files          17       17              
  Lines        1470     1445      -25     
==========================================
- Hits         1057     1036      -21     
+ Misses        413      409       -4     
Flag Coverage Δ
python 71.69% <ø> (-0.21%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 27 '25 13:03 codecov[bot]

@mattea-turic should be back online.

jpmartinspt avatar Mar 27 '25 13:03 jpmartinspt

Thanks, LGTM @jpmartinspt ! Just one more change, if you could have the page colour as paper, but I'll add a +1 for design as this is a very small fix

mattea-turic avatar Mar 27 '25 16:03 mattea-turic

@Sophie-32 ready for a UX review :)

jpmartinspt avatar Mar 28 '25 22:03 jpmartinspt