bundle-kubeflow icon indicating copy to clipboard operation
bundle-kubeflow copied to clipboard

AKS/EKS action is failing when called via `workflow_dispatch`

Open mvlassis opened this issue 1 year ago • 1 comments

Bug Description

Here is a relevant run of the failed action.

To Reproduce

  • Trigger a call on the AKS or EKS action via workflow dispatch

Environment

  • Branch: main

Relevant Log Output

The workflow is not valid. .github/workflows/deploy-to-eks.yaml (Line: 57, Col: 25): Unrecognized named-value: 'jobs'. Located at position 80 within expression: fromJSON(needs.preprocess-input.outputs.processed_bundle_versions) || fromJSON(jobs.generate-bundle-versions-on-schedule.outputs.bundle_versions) .github/workflows/deploy-to-eks.yaml (Line: 57, Col: 25): Unexpected value '${{ fromJSON(needs.preprocess-input.outputs.processed_bundle_versions) || fromJSON(jobs.generate-bundle-versions-on-schedule.outputs.bundle_versions) }}'

Additional Context

No response

mvlassis avatar Oct 25 '24 13:10 mvlassis

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6500.

This message was autogenerated

After a bit of troubleshooting with @orfeas-k, we concluded the following:

  • A job can only reference a job that it needs, otherwise sequential execution is not guaranteed.
  • It is not possible in Github Actions to have a conditional needs for a job. This means that we cannot have the deploy-ckf job depend on either the job that runs on schedule or the one that runs on workflow dispatch.
  • Thus, with the current structure we have to change the above 2 jobs to run always, which defeats the purpose of having 2 separate jobs.
  • We have decided it makes more sense to have a single job for preprocessing, and put the conditionals inside the run section.

mvlassis avatar Nov 14 '24 14:11 mvlassis